Programmatic imports#359
Merged
Merged
Conversation
|
|
Collaborator
Author
|
I just learned that Python 3.15 has language support for lazy imports. However, it will be a while before version 3.15 will be our minimum required version. So I propose we go with this direction for now and move to using language supported lazy imports later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292.
This cuts
import kernel_tunerimport time from about 2.78 s down to about 1.34 s, an improvement of roughly 1.44 s (~52%) on my laptop machine. There is a lot of variance in the measurements of import times however so the impact might not always be this large. But overall, I think the changes to the code are worth it in terms of time saving. Running a quick test is also noticeably faster.